PMD Results

The following document contains the results of PMD 3.9.

Files

org/apache/commons/jexl/ExpressionFactory.java

Violation Line
The class 'ExpressionFactory' has a Cyclomatic Complexity of 3 (Highest = 10). 56 - 179
The method 'createNewExpression' has a Cyclomatic Complexity of 10. 125 - 165
Caught exception is rethrown, original stack trace may be lost 137

org/apache/commons/jexl/junit/Asserter.java

Violation Line
Document empty constructor 50 - 52
Overridable method 'setVariable' called during object construction 61

org/apache/commons/jexl/resolver/FlatResolver.java

Violation Line
Document empty constructor 44 - 45

org/apache/commons/jexl/ScriptFactory.java

Violation Line
Caught exception is rethrown, original stack trace may be lost 171

org/apache/commons/jexl/util/ArrayListWrapper.java

Violation Line
Private field 'array' could be made final; it is only initialized in the declaration or constructor. 31

org/apache/commons/jexl/util/Coercion.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 17 - 161

org/apache/commons/jexl/util/GetExecutor.java

Violation Line
Avoid if (x != y) ..; else ..; 63 - 68

org/apache/commons/jexl/util/introspection/ClassMap.java

Violation Line
The class 'ClassMap' has a Cyclomatic Complexity of 4 (Highest = 12). 46 - 306
Overridable method 'getCachedClass' called during object construction 67
The method 'populateMethodCache' has a Cyclomatic Complexity of 12. 95 - 154
Use block level rather than method level synchronization 210 - 241
Use equals() to compare object references. 217
Avoid if (x != y) ..; else ..; 235
Use block level rather than method level synchronization 243 - 254

org/apache/commons/jexl/util/introspection/IntrospectionUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 18 - 168
The class 'IntrospectionUtils' has a Cyclomatic Complexity of 34 (Highest = 40). 29 - 168
The method isMethodInvocationConvertible() has an NPath complexity of 6531876 51 - 105
The method 'isMethodInvocationConvertible' has a Cyclomatic Complexity of 40. 51 - 105
Avoid reassigning parameters such as 'actual' 52
Avoid using if statements without curly braces 67 - 68
Avoid using if statements without curly braces 69 - 70
Avoid using if statements without curly braces 71 - 72
Avoid using if statements without curly braces 73 - 75
Avoid using if statements without curly braces 76 - 79
Avoid using if statements without curly braces 80 - 83
Avoid using if statements without curly braces 84 - 88
Avoid using if statements without curly braces 89 - 93
The method isStrictMethodInvocationConvertible() has an NPath complexity of 60504 123 - 167
The method 'isStrictMethodInvocationConvertible' has a Cyclomatic Complexity of 28. 123 - 167
Avoid reassigning parameters such as 'actual' 124
Avoid using if statements without curly braces 138 - 139
Avoid using if statements without curly braces 140 - 142
Avoid using if statements without curly braces 143 - 146
Avoid using if statements without curly braces 147 - 150
Avoid using if statements without curly braces 151 - 155

org/apache/commons/jexl/util/introspection/Introspector.java

Violation Line
Error while processing c:\svn\commons\commons-temp\jexl\src\java\org\apache\commons\jexl\util\introspection\Introspector.java 0

org/apache/commons/jexl/util/introspection/MethodMap.java

Violation Line
The class 'MethodMap' has a Cyclomatic Complexity of 5 (Highest = 15). 37 - 376
Switch statements should have a default label 181 - 203
Avoid using implementation types like 'LinkedList'; use the interface instead 289
The method 'isApplicable' has a Cyclomatic Complexity of 15. 311 - 363
Avoid unnecessary if..then..else statements when returning a boolean 317 - 322

org/apache/commons/jexl/util/introspection/UberspectImpl.java

Violation Line
Document empty method 71 - 72
Avoid if (x != y) ..; else ..; 142 - 154
Caught exception is rethrown, original stack trace may be lost 231
Avoid reassigning parameters such as 'o' 278
Avoid reassigning parameters such as 'params' 278
Avoid reassigning parameters such as 'actual' 333
Avoid reassigning parameters such as 'actual' 333

org/apache/commons/jexl/util/Introspector.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 17 - 55

org/apache/commons/jexl/util/MapGetExecutor.java

Violation Line
Overridable method 'discover' called during object construction 38

org/apache/commons/jexl/util/PropertyExecutor.java

Violation Line
Overridable method 'discover' called during object construction 51